Skip to content

Conversation

@tiran
Copy link
Member

@tiran tiran commented Mar 13, 2018

No description provided.

@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #182 into master will decrease coverage by <.01%.
The diff coverage is 60.8%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   70.22%   70.22%   -0.01%     
==========================================
  Files          49       49              
  Lines        4746     4816      +70     
  Branches      821      810      -11     
==========================================
+ Hits         3333     3382      +49     
- Misses       1067     1101      +34     
+ Partials      346      333      -13
Impacted Files Coverage Δ
Modules/common.c 83.33% <100%> (ø) ⬆️
Modules/message.c 32.93% <32.93%> (+0.4%) ⬆️
Modules/constants.c 45.83% <44.44%> (-1.23%) ⬇️
Modules/constants_generated.h 97.92% <50%> (-2.08%) ⬇️
Modules/functions.c 62.06% <51.35%> (+0.4%) ⬆️
Modules/ldapmodule.c 64% <66.66%> (ø) ⬆️
Modules/LDAPObject.c 66.84% <67.1%> (-0.85%) ⬇️
Modules/ldapcontrol.c 58.88% <67.24%> (+1.19%) ⬆️
Modules/options.c 86.66% <90.29%> (+6.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613b074...9a74c29. Read the comment docs.

@encukou
Copy link
Member

encukou commented Mar 14, 2018

This supersedes #2, right?

@tiran
Copy link
Member Author

tiran commented Mar 14, 2018

Mostly, this PR doesn't contain the autopep8 rule from PR #2.

@encukou
Copy link
Member

encukou commented Mar 14, 2018

Outstanding pull requests that touch C code are:

@tiran, are you OK rebasing #64 once I merge autoformatting for C?

No need to rebase this PR; I'll run the script just before committing.

@tiran
Copy link
Member Author

tiran commented Mar 14, 2018

Yes, I'll handle #64 myself. The PR needs some more work.

Generated with:

    make indent
    make indent
@encukou encukou merged commit 9a74c29 into python-ldap:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants