Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented Jan 10, 2018

No description provided.

@tiran
Copy link
Member

tiran commented Jan 10, 2018

How do you feel about calling it release candidate 1 instead of beta 4?

@codecov
Copy link

codecov bot commented Jan 10, 2018

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files          49       49           
  Lines        4731     4731           
  Branches      817      817           
=======================================
  Hits         3291     3291           
  Misses       1085     1085           
  Partials      355      355
Impacted Files Coverage Δ
Lib/ldapurl.py 78.1% <100%> (ø) ⬆️
Lib/ldif.py 75.96% <100%> (ø) ⬆️
Lib/ldap/pkginfo.py 100% <100%> (ø) ⬆️
Lib/slapdtest/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91438fd...35294a7. Read the comment docs.

@encukou
Copy link
Member Author

encukou commented Jan 10, 2018

Next time. If there is a next time :)

@encukou encukou merged commit ad46c11 into python-ldap:master Jan 10, 2018
@encukou encukou deleted the beta4 branch January 10, 2018 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants