Skip to content

Conversation

@jdufresne
Copy link
Member

  • Trim whitespace from end of lines
  • Trim whitespace from end of files

Helps avoid spurious changes during pull requests, which leads to cleaner diffs during code reviews.

- Trim whitespace from end of lines
- Trim whitespace from end of files

Helps avoid spurious changes during pull requests, which leads to
cleaner diffs during code reviews.
@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 42.85%.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files          49       49           
  Lines        4694     4694           
  Branches      789      789           
=======================================
  Hits         3233     3233           
  Misses       1111     1111           
  Partials      350      350
Impacted Files Coverage Δ
Modules/message.c 32.53% <ø> (ø) ⬆️
Lib/ldap/constants.py 54.9% <ø> (ø) ⬆️
Lib/ldap/controls/deref.py 57.14% <ø> (ø) ⬆️
Modules/ldapcontrol.c 57.45% <ø> (ø) ⬆️
Lib/ldapurl.py 78.1% <ø> (ø) ⬆️
Modules/functions.c 61.66% <0%> (ø) ⬆️
Modules/options.c 80.48% <0%> (ø) ⬆️
Modules/common.c 83.33% <100%> (ø) ⬆️
Modules/LDAPObject.c 67.69% <45.45%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673957d...a130046. Read the comment docs.

@tiran
Copy link
Member

tiran commented Dec 12, 2017

Thanks for your contribution. We are planning to to a full code reformatting of C code and Python code eventually, see PR #2 . Could you please add a comment to the PR and post the command you have used?

@encukou
Copy link
Member

encukou commented Dec 12, 2017

Thanks for the suggestion!

As @tiran said, we're delaying wholesale code reformatting – solely because there are/were a lot of in-progress patches that would need rebasing.
Now, this particular PR doesn't look hard to rebase onto, so I wouldn't mind merging it if you really want it in for 3.0. After 3.0, we'll run autopep8 to fix all the whitespace. (I don't think an extra command will be needed.)

I'll close the PR, but feel free to re-open. Avoid changing non-code files though: .github/ISSUE_TEMPLATE.md has the spaces on purpose, and PEM certificates are generated data.

@encukou encukou closed this Dec 12, 2017
@jdufresne jdufresne deleted the ws branch December 12, 2017 14:39
@jdufresne jdufresne restored the ws branch December 13, 2017 02:37
@jdufresne jdufresne deleted the ws branch December 13, 2017 02:38
@jdufresne
Copy link
Member Author

Could you please add a comment to the PR and post the command you have used?

The command is:

$ find . -name .git -prune -o -type f -exec emacs -q -batch {} -eval "(require 'whitespace)" -eval "(let ((whitespace-style '(empty trailing))) (whitespace-cleanup))" -f save-buffer \; 

With some slight post processing to revert auto-generated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants