Skip to content

Commit 3aca52d

Browse files
author
Martin J. Laubach
committed
Add option admin_list_display to contrib.tagging, so one can turn that off.
Turning on the tags in admin's changelist incurs a db query for every item, which adds up fast. No idea why django-tagging is not using the value cached in the db field but instead rebuilds the tag list from scratch every time.
1 parent 1f367b2 commit 3aca52d

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎feincms/contrib/tagging.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def pre_save_handler(sender, instance, **kwargs):
8686

8787

8888
# ------------------------------------------------------------------------
89-
def tag_model(cls, admin_cls=None, field_name='tags', sort_tags=False, select_field=False, auto_add_admin_field=True):
89+
def tag_model(cls, admin_cls=None, field_name='tags', sort_tags=False, select_field=False, auto_add_admin_field=True, admin_list_display=True):
9090
"""
9191
tag_model accepts a number of named parameters:
9292
@@ -115,7 +115,8 @@ def tag_model(cls, admin_cls=None, field_name='tags', sort_tags=False, select_fi
115115
return
116116

117117
if admin_cls:
118-
admin_cls.list_display.append(field_name)
118+
if admin_list_display:
119+
admin_cls.list_display.append(field_name)
119120
admin_cls.list_filter.append(field_name)
120121

121122
if auto_add_admin_field and hasattr(admin_cls, 'add_extension_options'):

0 commit comments

Comments
 (0)