Skip to content

Handle unknown light effect names and only calculate effect list once #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 1 commit into from
Jun 11, 2024
Merged

Handle unknown light effect names and only calculate effect list once #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions kasa/smart/modules/lightstripeffect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,27 @@

from __future__ import annotations

from typing import TYPE_CHECKING

from ...interfaces.lighteffect import LightEffect as LightEffectInterface
from ..effects import EFFECT_MAPPING, EFFECT_NAMES
from ..smartmodule import SmartModule

if TYPE_CHECKING:
from ..smartdevice import SmartDevice


class LightStripEffect(SmartModule, LightEffectInterface):
"""Implementation of dynamic light effects."""

REQUIRED_COMPONENT = "light_strip_lighting_effect"

def __init__(self, device: SmartDevice, module: str):
super().__init__(device, module)
effect_list = [self.LIGHT_EFFECTS_OFF]
effect_list.extend(EFFECT_NAMES)
self._effect_list = effect_list

@property
def name(self) -> str:
"""Name of the module.
Expand All @@ -37,7 +48,8 @@ def effect(self) -> str:
"""
eff = self.data["lighting_effect"]
name = eff["name"]
if eff["enable"]:
# When devices are unpaired effect name is softAP which is not in our list
if eff["enable"] and name in self._effect_list:
return name
return self.LIGHT_EFFECTS_OFF

Expand All @@ -48,9 +60,7 @@ def effect_list(self) -> list[str]:
Example:
['Aurora', 'Bubbling Cauldron', ...]
"""
effect_list = [self.LIGHT_EFFECTS_OFF]
effect_list.extend(EFFECT_NAMES)
return effect_list
return self._effect_list

async def set_effect(
self,
Expand Down