Skip to content

Add LightEffect module for smart light strips #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdb9696 merged 2 commits into from
May 15, 2024
Merged

Add LightEffect module for smart light strips #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f092ff
Add smart common light effect module
sdb9696 May 14, 2024
1d1cb0a
Update post review
sdb9696 May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions kasa/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,11 +911,12 @@ async def effect(dev: Device, ctx, effect):
echo("Device does not support effects")
return
if effect is None:
raise click.BadArgumentUsage(
"Setting an effect requires a named built-in effect: "
+ f"{light_effect.effect_list}",
ctx,
echo(
f"Light effect: {light_effect.effect}\n"
+ f"Available Effects: {light_effect.effect_list}"
)
return light_effect.effect

if effect not in light_effect.effect_list:
raise click.BadArgumentUsage(
f"Effect must be one of: {light_effect.effect_list}", ctx
Expand Down
11 changes: 5 additions & 6 deletions kasa/iot/modules/lighteffect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,11 @@ def effect(self) -> str:
'id': '',
'name': ''}
"""
if (
(state := self.data.get("lighting_effect_state"))
and state.get("enable")
and (name := state.get("name"))
and name in EFFECT_NAMES_V1
):
eff = self.data["lighting_effect_state"]
name = eff["name"]
if eff["enable"]:
return name

return self.LIGHT_EFFECTS_OFF

@property
Expand Down Expand Up @@ -67,6 +65,7 @@ async def set_effect(
raise ValueError(f"The effect {effect} is not a built in effect.")
else:
effect_dict = EFFECT_MAPPING_V1[effect]

if brightness is not None:
effect_dict["brightness"] = brightness
if transition is not None:
Expand Down
Loading