Skip to content

Update dump_devinfo to print original exception stack on errors. #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdb9696 merged 2 commits into from
Apr 29, 2024
Merged

Update dump_devinfo to print original exception stack on errors. #882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b40af8
Fix smartprotocol response list handler to handle null reponses
sdb9696 Apr 29, 2024
bf5fdea
Merge branch 'master' into fix/dump_devinfo
sdb9696 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion devtools/dump_devinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import json
import logging
import re
import sys
import traceback
from collections import defaultdict, namedtuple
from pathlib import Path
Expand Down Expand Up @@ -343,6 +344,26 @@ def _echo_error(msg: str):
)


def format_exception(e):
"""Print full exception stack as if it hadn't been caught.

https://stackoverflow.com/a/12539332
"""
exception_list = traceback.format_stack()
exception_list = exception_list[:-2]
exception_list.extend(traceback.format_tb(sys.exc_info()[2]))
exception_list.extend(
traceback.format_exception_only(sys.exc_info()[0], sys.exc_info()[1])
)

exception_str = "Traceback (most recent call last):\n"
exception_str += "".join(exception_list)
# Removing the last \n
exception_str = exception_str[:-1]

return exception_str


async def _make_requests_or_exit(
device: SmartDevice,
requests: list[SmartRequest],
Expand Down Expand Up @@ -389,7 +410,7 @@ async def _make_requests_or_exit(
f"Unexpected exception querying {name} at once: {ex}",
)
if _LOGGER.isEnabledFor(logging.DEBUG):
traceback.print_stack()
_echo_error(format_exception(ex))
exit(1)
finally:
await device.protocol.close()
Expand Down