'Interface' parameter added to discovery process #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems (for example dd-wrt) requires specifying the network interface name, otherwise the broadcast does not work
rytilahti
reviewed
Jun 26, 2020
rytilahti
reviewed
Jun 26, 2020
Co-authored-by: Teemu R. <tpr@iki.fi>
Member
|
This is good to go when the linting checks pass, thanks for the PR! 🎉 edit: please rebase on top of the current master, and add a simple example at the end of the other docstring examples. there is no need to create any specific tests for this, just a code example showing how (and why) this can be used. |
Member
|
So, I don't really see why this isn't passing when it should. I have tried to restart the checks, but that doesn't seem to be working either and clicking to see what was failing returns "Build not found.". As the code seems fine now, let's get this merged and fix it later if needed (which I doubt, maybe the pipeline was just bugged). Thanks for the PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems (for example dd-wrt routers) requires specifying the network interface name, otherwise the broadcast search does not work. Optional parameter 'interface' added.
Usage example: