Skip to content

Conversation

@rytilahti
Copy link
Member

@rytilahti rytilahti commented Jan 29, 2024

  • Separate fake protocols for iot and smart, rename FakeTransportProtocol to FakeIotProtocol.
  • Cleanup fakeprotocol_iot by moving schemas into their respective test files

@rytilahti rytilahti changed the title Separate fake protocols for iot and smart Various test code cleanups Jan 29, 2024
@rytilahti rytilahti marked this pull request as ready for review January 29, 2024 18:17
@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8e2739) 87.96% compared to head (a8d11f0) 87.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files          41       41           
  Lines        3630     3630           
  Branches      909      909           
=======================================
  Hits         3193     3193           
  Misses        362      362           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rytilahti rytilahti merged commit 9e6896a into python-kasa:master Jan 29, 2024
@rytilahti rytilahti deleted the janitor/cleanup_tests branch January 29, 2024 19:26
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Feb 2, 2024
[Full Changelog](python-kasa/python-kasa@0.6.2...0.6.2.1)

**Fixed bugs:**

- Avoid crashing on childdevice property accesses [\python-kasa#732](python-kasa#732) (@rytilahti)

**Merged pull requests:**

- Retain last two chars for children device\_id [\python-kasa#733](python-kasa#733) (@rytilahti)
- Add TP15 fixture [\python-kasa#730](python-kasa#730) (@bdraco)
- Add TP25 fixtures [\python-kasa#729](python-kasa#729) (@bdraco)
- Various test code cleanups [\python-kasa#725](python-kasa#725) (@rytilahti)
- Unignore F401 for tests [\python-kasa#724](python-kasa#724) (@rytilahti)
@rytilahti rytilahti mentioned this pull request Feb 2, 2024
rytilahti added a commit that referenced this pull request Feb 2, 2024
[Full Changelog](0.6.2...0.6.2.1)

**Fixed bugs:**

- Avoid crashing on childdevice property accesses [\#732](#732) (@rytilahti)

**Merged pull requests:**

- Retain last two chars for children device\_id [\#733](#733) (@rytilahti)
- Add TP15 fixture [\#730](#730) (@bdraco)
- Add TP25 fixtures [\#729](#729) (@bdraco)
- Various test code cleanups [\#725](#725) (@rytilahti)
- Unignore F401 for tests [\#724](#724) (@rytilahti)
@rytilahti rytilahti mentioned this pull request Feb 15, 2024
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Project improvements and maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants