Add known smart requests to dump_devinfo #597
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 84.94% 84.94%
=======================================
Files 38 38
Lines 3387 3387
Branches 851 851
=======================================
Hits 2877 2877
Misses 424 424
Partials 86 86 ☔ View full report in Codecov by Sentry. |
sdb9696
force-pushed
the
add_dumpdevinfo_methods
branch
from
4006c92 to
708c72b
Compare
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
How about we move smartrequests (or its contents?) into the devtools until we figure out what's the best approach to do this? This way we wouldn't commit into keeping this around and/or breaking it too soon, while still allowing us to get more complete fixtures after a new release is done.
Ok that's done |
devtools/dump_devinfo.py
Outdated
| try: | ||
| responses = await device.protocol.query(final_query) | ||
| end = len(requests) | ||
| step = 10 # Break the requests down as there seems to be a size limit |
There was a problem hiding this comment.
We introduced some API in #502 to help with such issues, maybe we should implement this for tapo* classes, too? I doubt this is necessary for the 0.6.0 release, but something to keep in mind to look at some point.
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Just a couple of minor nits, I didn't check out the smartrequests itself as this is hopefully rather temporary solution until we figure out how we want to handle components/modules inside the library itself.
2 participants
No description provided.