Optimize I/O access #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is the last showstopper I wanted to tackle before making a release. It may not be be prettiest code you have ever seen, but I think it's the time to get the first (pre-)release out and let the downstream users to enjoy the improvements, at last.. edit: I think there is one more thing that should be done pre-release: getting rid of implicit |
rytilahti
added a commit
to rytilahti/home-assistant
that referenced
this pull request
May 16, 2020
the backend lib will after python-kasa/python-kasa#59 fetch all the necessary wanted in a single update cycle.
This was referenced May 16, 2020
kirichkov
approved these changes
May 20, 2020
Contributor
|
I'm in favor of removing the automatic updates everywhere. I think it should be up to the user of the library to determine when its best to ask for information. |
A single update() will now fetch information from all interesting modules, including the current device state and the emeter information. In practice, this will allow dropping the number of I/O reqs per homeassistant update cycle to 1, which is paramount at least for bulbs which are very picky about sequential accesses. This can be further extend to other modules/methods, if needed. Currently fetched data: * sysinfo * realtime, today's and this months emeter stats New properties: * emeter_realtime: return the most recent emeter information, update()-version of get_emeter_realtime() * emeter_today: returning today's energy consumption * emeter_this_month: same for this month Other changes: * Accessing @requires_update properties will cause SmartDeviceException if the device has not ever been update()d * Fix __repr__ for devices that haven't been updated * Smartbulb uses now the state data from get_sysinfo instead of separately querying the bulb service * SmartStrip's state_information no longer lists onsince for separate plugs * The above mentioned properties are now printed out by cli * Simplify is_on handling for bulbs
…README.md instructions. fixes python-kasa#61
rytilahti
force-pushed
the
refactor/request_combine
branch
from
9c641a5 to
4faa24a
Compare
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 78.73% 76.27% -2.47%
==========================================
Files 7 7
Lines 790 826 +36
Branches 104 110 +6
==========================================
+ Hits 622 630 +8
- Misses 150 172 +22
- Partials 18 24 +6
Continue to review full report at Codecov.
|
Member
Author
|
I presume that we can merge this now (and fix any issues in future PRs). |
rytilahti
added a commit
to rytilahti/home-assistant
that referenced
this pull request
May 24, 2020
the backend lib will after python-kasa/python-kasa#59 fetch all the necessary wanted in a single update cycle.
rytilahti
added a commit
to rytilahti/home-assistant
that referenced
this pull request
Jun 4, 2020
the backend lib will after python-kasa/python-kasa#59 fetch all the necessary wanted in a single update cycle.
rytilahti
added a commit
to rytilahti/home-assistant
that referenced
this pull request
Jun 30, 2020
the backend lib will after python-kasa/python-kasa#59 fetch all the necessary wanted in a single update cycle.
rytilahti
added a commit
to rytilahti/home-assistant
that referenced
this pull request
Jul 23, 2020
the backend lib will after python-kasa/python-kasa#59 fetch all the necessary wanted in a single update cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single update() will now fetch information from all interesting modules,
including the current device state and the emeter information.
In practice, this will allow dropping the number of I/O reqs per homeassistant update cycle to 1,
which is paramount at least for bulbs which are very picky about sequential accesses.
This can be further extend to other modules/methods, if needed.
This will also remove the implicit
update()calls from device state changing methods such asset_brightness(). This allows executing multiple changes on a device without unnecessary I/O.Currently fetched data:
New properties:
Other changes:
Closes #53, closes #61.