Fix transport retries after close #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 79.50% 79.66% +0.16%
==========================================
Files 36 36
Lines 2991 2995 +4
Branches 777 779 +2
==========================================
+ Hits 2378 2386 +8
+ Misses 541 536 -5
- Partials 72 73 +1 ☔ View full report in Codecov by Sentry. |
rytilahti
approved these changes
Dec 5, 2023
Member
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Fixes the issue with dump_devinfo for me, thanks! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the transport does not recover after
close()is called by the protocol.Tests are updated to mock the underlying
httpx.AsyncClient.postinstead of the transportclient_postwhich would now catch the issue.