Re-add regional suffix to TAPO/SMART fixtures #566
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 79.66% 79.66%
=======================================
Files 36 36
Lines 2995 2995
Branches 779 779
=======================================
Hits 2386 2386
Misses 536 536
Partials 73 73 ☔ View full report in Codecov by Sentry. |
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Looks like dump_devinfo is currently broken for me:
Testing Call(module='child_device_component_list', method='get_child_device_component_list')..FAIL Unable to connect to the device: 192.168.xx.xx: 'NoneType' object has no attribute 'cookies'
Unable to query all successes at once: Unable to connect to the device: 192.168.xx.xx: 'NoneType' object has no attribute 'cookies'
The device responds with {"error_code":-1002} to that call and fails after retries.
|
Hmm that's strange, I got a similar error testing my HA changes today. I'll spend a bit more time on this tomorrow. |
|
I think this should be fixed in #568. I'm guessing the AesTransport returns the error code pre-decryption so it raises an error from the transport which hit a bug in the retry logic (introduced to make mypy happy). This does mean it'll probably retry this query even though it's returning a non-authentication error code so there's probably a bit of work to do interpreting the error codes. Sadly I can't test with my device anymore. I'll rebase this once #568 is in so you can re-test. |
sdb9696
force-pushed
the
readd_tapo_regional_fixture
branch
from
71f81c6 to
c97a872
Compare
|
Not ready for merge yet. It seems this EDIT: Ok this is ready for merge. Made some tweaks to tell users to put the file in the smart subdirectory. |
sdb9696
force-pushed
the
readd_tapo_regional_fixture
branch
from
c97a872 to
2bd670b
Compare
2 participants
No description provided.