Skip to content

Conversation

@rytilahti
Copy link
Member

To be merged after #557.

@rytilahti rytilahti marked this pull request as ready for review December 4, 2023 18:56
@rytilahti
Copy link
Member Author

@sdb9696 looks like your UK variant includes a couple of new "components" besides the protocol change. I'm wondering if we should keep including the complete model name in the filenames like it was done for the legacy fixtures?

@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e2fcd2) 79.66% compared to head (003911d) 79.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files          36       36           
  Lines        2995     2995           
  Branches      779      779           
=======================================
  Hits         2386     2386           
  Misses        536      536           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696
Copy link
Collaborator

sdb9696 commented Dec 4, 2023

@sdb9696 looks like your UK variant includes a couple of new "components" besides the protocol change. I'm wondering if we should keep including the complete model name in the filenames like it was done for the legacy fixtures?

Yes I realised I inadvertently dropped the regional variant and plan to fix very soon. :-)

@sdb9696
Copy link
Collaborator

sdb9696 commented Dec 4, 2023

@sdb9696 looks like your UK variant includes a couple of new "components" besides the protocol change. I'm wondering if we should keep including the complete model name in the filenames like it was done for the legacy fixtures?

Yes I realised I inadvertently dropped the regional variant and plan to fix very soon. :-)

#566

@sdb9696
Copy link
Collaborator

sdb9696 commented Dec 5, 2023

Apologies you'll need to regenerate this with the latest #566 as it still has the .smart suffix which we removed in favour of subfolders.

@rytilahti
Copy link
Member Author

rytilahti commented Dec 5, 2023

No worries, I just renamed it (based on the filename given out using the PR) :-)

@rytilahti rytilahti merged commit 5febd30 into python-kasa:master Dec 5, 2023
@rytilahti rytilahti deleted the add_p110_fixture branch December 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants