-
-
Notifications
You must be signed in to change notification settings - Fork 239
Add P110 fixture #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add P110 fixture #562
Conversation
aa019ee to
557ed43
Compare
|
@sdb9696 looks like your UK variant includes a couple of new "components" besides the protocol change. I'm wondering if we should keep including the complete model name in the filenames like it was done for the legacy fixtures? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 79.66% 79.66%
=======================================
Files 36 36
Lines 2995 2995
Branches 779 779
=======================================
Hits 2386 2386
Misses 536 536
Partials 73 73 ☔ View full report in Codecov by Sentry. |
Yes I realised I inadvertently dropped the regional variant and plan to fix very soon. :-) |
|
|
Apologies you'll need to regenerate this with the latest #566 as it still has the .smart suffix which we removed in favour of subfolders. |
|
No worries, I just renamed it (based on the filename given out using the PR) :-) |
61c0624 to
003911d
Compare
To be merged after #557.