-
-
Notifications
You must be signed in to change notification settings - Fork 239
Update dump_devinfo to produce new TAPO/SMART fixtures #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 75.84% 75.84% -0.01%
==========================================
Files 33 34 +1
Lines 2861 2865 +4
Branches 747 747
==========================================
+ Hits 2170 2173 +3
- Misses 634 635 +1
Partials 57 57 ☔ View full report in Codecov by Sentry. |
|
@ezekieldas this PR will allow us to be able to create test fixtures for the devices using the TAPO/SMART protocol like your EP25. I don't suppose you'd able to checkout this PR and run it against your EP25? Command would be something like:
The output should be auto masked for sensitive data but please double check because the masking is new for this protocol. If you could then upload the file that would be great, thanks! |
|
Two files attached here. Note the |
That's great thanks @ezekieldas. The error in the stdout is expected because the tool tries to get all modules without knowing if the device supports them or not. Glad to see it works and thanks for the fixture. This PR may interest you because I know you're trying to get energy monitoring in HA with your device. If it works you may want to try it in HA and see if it gives you the graphs you're looking for (if you're not sure how to test a dependency PR in HA I can help but not tonight I'm afraid) |
rytilahti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sending you email on this as to not clutter up these comments. |
We need to be careful not merge any of these new fixtures without the test framework changes in #557 or they will break the tests.