Make device port configurable #471
Conversation
karpach
force-pushed
the
master
branch
2 times, most recently
from
ae44a85 to
aeef0ac
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
==========================================
+ Coverage 79.50% 79.55% +0.04%
==========================================
Files 26 26
Lines 1952 1956 +4
Branches 598 599 +1
==========================================
+ Hits 1552 1556 +4
Misses 359 359
Partials 41 41
☔ View full report in Codecov by Sentry. |
karpach
force-pushed
the
master
branch
3 times, most recently
from
e1eeb80 to
ece85fb
Compare
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Thanks for the update, see my comments inline. Basically, I think we should avoid hardcoding the protocol-specific port constant on all the Device-inherited classes and leave it to the protocol class to handle. This not only makes it more extendable, if need to be (#471), but will also simplify the code a bit.
karpach
force-pushed
the
master
branch
6 times, most recently
from
69d1bcd to
b62f225
Compare
karpach
force-pushed
the
master
branch
2 times, most recently
from
b62f225 to
6199521
Compare
5 participants
My use case is very similar to the discussion #410.
I have an internal network with IoT devices. The network is separated from my home network, so rouge IoT devices don't have the ability to hack my PCs (that happened once). I only expose ports that IoT devices need. Since I have multiple tp-link kasa devices, I need to do port forwarding to different ports.