Skip to content

Exclude querying certain modules for KL125(US) which cause crashes #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 10 commits into from
May 18, 2023
+9 −1
Merged

Exclude querying certain modules for KL125(US) which cause crashes #451

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4ae9a32
commented out modules that break
brianthedavis Apr 26, 2023
a286b15
added exclusion logic to smartdevice.py
brianthedavis Apr 26, 2023
9a8cfcc
cleaning up a name
brianthedavis Apr 26, 2023
9bee885
removing test fixture that isn't related to this PR
brianthedavis May 2, 2023
fe39462
incorporating PR feedback
brianthedavis May 2, 2023
f75468c
fixed an if statement
brianthedavis May 2, 2023
36dd468
reduced exclusion list to just 'cloud'
brianthedavis May 2, 2023
c882768
Tidy up the issue comment
brianthedavis May 17, 2023
a017f35
Merge branch 'python-kasa:master' into issue_345
brianthedavis May 17, 2023
6acd809
this seems to be what the linter whats
brianthedavis May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion kasa/smartdevice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@

_LOGGER = logging.getLogger(__name__)

# Certain module queries will crash devices; this list skips those queries
MODEL_MODULE_SKIPLIST = {"KL125(US)": ["cloud"]} # Issue #345


class DeviceType(Enum):
"""Device type enum."""
Expand Down Expand Up @@ -325,10 +328,15 @@ async def _modular_update(self, req: dict) -> None:
)
self.add_module("emeter", Emeter(self, self.emeter_type))

for module in self.modules.values():
for module_name, module in self.modules.items():
if not module.is_supported:
_LOGGER.debug("Module %s not supported, skipping" % module)
continue
modules_to_skip = MODEL_MODULE_SKIPLIST.get(self.model, [])
if module_name in modules_to_skip:
_LOGGER.debug(f"Module {module} is excluded for {self.model}, skipping")
continue

q = module.query()
_LOGGER.debug("Adding query for %s: %s", module, q)
req = merge(req, q)
Expand Down