Ensure bulb state is restored when turning back on #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Apr 5, 2022
22 tasks
Member
Author
|
Looks like the CI is broken for unrelated reasons |
Member
|
CI fix in #331 |
rytilahti
reviewed
Apr 5, 2022
Co-authored-by: Teemu R. <tpr@iki.fi>
bdraco
force-pushed
the
restore_state_turning_back_on
branch
from
25620e4 to
fbcf717
Compare
Member
Author
|
Looks like the CI is passing sans the docs which don't look related to this change |
Member
Author
|
@rytilahti If this is ok now, I was hoping to get a new release to fix home-assistant/core#69039 before beta is finished up (and before modularize merges). |
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 82.34% 82.37% +0.03%
==========================================
Files 13 13
Lines 1376 1379 +3
Branches 202 203 +1
==========================================
+ Hits 1133 1136 +3
Misses 201 201
Partials 42 42
Continue to review full report at Codecov.
|
rytilahti
changed the title
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](python-kasa/python-kasa@0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\python-kasa#292](python-kasa#292) - Ensure bulb state is restored when turning back on [\python-kasa#330](python-kasa#330) (@bdraco) **Closed issues:** - KL420L5 controls [\python-kasa#327](python-kasa#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\python-kasa#331](python-kasa#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\python-kasa#325](python-kasa#325) (@bdraco)
Merged
rytilahti
added a commit
that referenced
this pull request
Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\#292](#292) - Ensure bulb state is restored when turning back on [\#330](#330) (@bdraco) **Closed issues:** - KL420L5 controls [\#327](#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\#331](#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\#325](#325) (@bdraco)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#69039