Skip to content

Fix unsafe __del__ in TPLinkSmartHomeProtocol #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 4 commits into from
Jan 30, 2022
Merged

Fix unsafe __del__ in TPLinkSmartHomeProtocol #300

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
139b8a6
Fix unsafe __del__ in TPLinkSmartHomeProtocol
bdraco Jan 29, 2022
845aa23
comment
bdraco Jan 30, 2022
a126f2a
comment
bdraco Jan 30, 2022
d804a19
comment
bdraco Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kasa/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,11 @@ async def _query(self, request: str, retry_count: int, timeout: int) -> Dict:

def __del__(self) -> None:
if self.writer and self.loop and self.loop.is_running():
self.writer.close()
# Since __del__ will be called when python does
# garbage collection is can happen in the event loop thread
# or in another thread so we need to make sure the call to
# close is called safely with call_soon_threadsafe
self.loop.call_soon_threadsafe(self.writer.close)
self._reset()

@staticmethod
Expand Down