H500 hub fixture#1718
Open
jimboca wants to merge 8 commits into
Open
Conversation
Explain that getDeviceInfo.child_num can disagree with an empty getChildDeviceList over LAN, add Read the Docs hub guide, warn in dump_devinfo and SmartCamDevice when that happens, and ship an H500 hub-only fixture with matching test/fake-protocol guards. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore getConnectionType and getFirmwareAutoUpgradeConfig from a successful dump_devinfo run so H500 parametrized tests pass. Handle wedged-hub dumps with no successful probes, and tolerate H500 list responses that omit child list fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes pre-commit ruff-format failure on PR python-kasa#1718. Co-authored-by: Cursor <cursoragent@cursor.com>
Pretty-format the H500 smartcam fixture JSON and regenerate README.md and SUPPORTED.md for the new hub entry. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1718 +/- ##
==========================================
+ Coverage 93.21% 93.24% +0.02%
==========================================
Files 157 157
Lines 9819 9838 +19
Branches 1005 1011 +6
==========================================
+ Hits 9153 9173 +20
Misses 472 472
+ Partials 194 193 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cover warning paths in smartprotocol, smartdevice, and smartcamdevice so codecov patch checks pass for PR python-kasa#1718. Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes ruff-format pre-commit failure on PR python-kasa#1718. Co-authored-by: Cursor <cursoragent@cursor.com>
Cast malformed hub response dicts passed to _create_delete_children so pre-commit mypy passes on PR python-kasa#1718. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Update on H500 child enumeration (live hub, FW 1.3.18)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the H500 fixture and confirmed all tests pass.
I have cameras added to the hub and it reports it has children, but doesn't actually list the children. I can't figure out if there is another way to get that information. Let me know if you have any suggestions.