Add support for Tapo H110 IR Air Conditioners #1716
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ __pycache__/ | |
|
|
||
| # Coverage | ||
| .coverage | ||
| coverage.xml | ||
|
|
||
| # Tox | ||
| .tox | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| """Smart IR AC child device implementation.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
| from typing import Any | ||
|
|
||
| from ..device_type import DeviceType | ||
| from .smartchilddevice import SmartChildDevice | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class SmartIrAC(SmartChildDevice): | ||
| """Presentation of a child IR Air Conditioner device.""" | ||
|
|
||
| def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
| self._ac_state: dict[str, int] = {} | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| @property | ||
| def device_type(self) -> DeviceType: | ||
| """Return the device type.""" | ||
| try: | ||
| return DeviceType.Climate | ||
| except AttributeError: | ||
| return DeviceType.Thermostat | ||
|
Comment on lines
+22
to
+27
|
||
|
|
||
| def _update_internal_state(self, info: dict[str, Any]) -> None: | ||
| """Update the internal info state.""" | ||
| super()._update_internal_state(info) | ||
|
|
||
| ac_status = info.get("ac_status") | ||
|
Member
There was a problem hiding this comment. We want to have a less fragile parsing of the status. I cannot off the bat recommend how it should look like (could you create a PR to add a fixture?), but we want to make it more robust to avoid breaking if the device responses change suddenly. If this is a regular smart device, maybe it is only necessary to implement a module to handle this case? Let me know what do you think & if you need any help with deciphering how to bolt modules in! |
||
| if ac_status: | ||
| parts = ac_status.split("_") | ||
| self._ac_state = {} | ||
| for part in parts: | ||
| if len(part) >= 2: | ||
| key = part[0] | ||
| try: | ||
| value = int(part[1:]) | ||
| self._ac_state[key] = value | ||
| except ValueError: | ||
| pass | ||
|
|
||
| @property | ||
| def is_on(self) -> bool: | ||
| """Return true if the device is on.""" | ||
| return bool(self._ac_state.get("P", 0)) | ||
|
|
||
| @property | ||
| def target_temperature(self) -> int | None: | ||
| """Return the target temperature.""" | ||
| return self._ac_state.get("T") | ||
|
|
||
| @property | ||
| def hvac_mode(self) -> int | None: | ||
| """Return the hvac mode.""" | ||
| return self._ac_state.get("M") | ||
|
|
||
| @property | ||
| def fan_mode(self) -> int | None: | ||
| """Return the fan mode.""" | ||
| return self._ac_state.get("S") | ||
|
|
||
| @property | ||
| def swing_mode(self) -> int | None: | ||
| """Return the swing mode.""" | ||
| return self._ac_state.get("D") | ||
|
|
||
| async def _send_ir_cmd(self, **kwargs) -> dict: | ||
| """Send IR command to the AC.""" | ||
| payload = { | ||
| "power": bool(self._ac_state.get("P", 0)), | ||
| "on": bool(self._ac_state.get("P", 0)), | ||
| "mode": self._ac_state.get("M", 1), | ||
| "temp": self._ac_state.get("T", 24), | ||
| "wind_speed": self._ac_state.get("S", 1), | ||
| "wind_direct": self._ac_state.get("D", 0), | ||
| } | ||
|
|
||
| for key, value in kwargs.items(): | ||
| payload[key] = value | ||
| if key == "power": | ||
| payload["on"] = value | ||
|
|
||
| request = { | ||
| "multipleRequest": { | ||
| "requests": [{"method": "sendIrCmdByStatus", "params": payload}] | ||
| } | ||
| } | ||
|
|
||
| if "power" in payload: | ||
| self._ac_state["P"] = 1 if payload["power"] else 0 | ||
| if "mode" in payload: | ||
| self._ac_state["M"] = payload["mode"] | ||
| if "temp" in payload: | ||
| self._ac_state["T"] = payload["temp"] | ||
| if "wind_speed" in payload: | ||
| self._ac_state["S"] = payload["wind_speed"] | ||
| if "wind_direct" in payload: | ||
| self._ac_state["D"] = payload["wind_direct"] | ||
|
|
||
| return await self.protocol.query(request) | ||
|
|
||
| async def set_target_temperature(self, temp: int) -> dict: | ||
| """Set the target temperature.""" | ||
| return await self._send_ir_cmd(temp=temp) | ||
|
|
||
| async def set_hvac_mode(self, mode: int) -> dict: | ||
| """Set the hvac mode.""" | ||
| return await self._send_ir_cmd(mode=mode) | ||
|
|
||
| async def set_fan_mode(self, speed: int) -> dict: | ||
| """Set the fan mode.""" | ||
| return await self._send_ir_cmd(wind_speed=speed) | ||
|
|
||
| async def set_swing_mode(self, swing: int) -> dict: | ||
| """Set the swing mode.""" | ||
| return await self._send_ir_cmd(wind_direct=swing) | ||
|
|
||
| async def turn_on(self, **kwargs: Any) -> dict: | ||
| """Turn on the AC.""" | ||
| return await self._send_ir_cmd(power=True) | ||
|
|
||
| async def turn_off(self, **kwargs: Any) -> dict: | ||
| """Turn off the AC.""" | ||
| return await self._send_ir_cmd(power=False) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a child device, there should be no need to export this.