fix: add support for TPAP encryption type (closes #1590)#1706
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
fix: add support for TPAP encryption type (closes #1590)#1706botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
Collaborator
|
There is already an existing, extensively tested PR that handles all of the CLI and API changes, #1592, we are working to get this implemented and a new version released soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Some devices (e.g., TAPO RV30 Max firmware 1.3.0) use a new encryption scheme called TPAP. The current code raises an Unsupported device error when encountering this encrypt_type.
Fix
Check the config encrypt_type and pass it to the transport so that TPAP can be handled. The actual encryption logic (e.g., TLS-based PAKE) must be implemented in the AesTransport class separately. This change ensures the device is accepted and can proceed to establish a connection.
Closes #1590