Expose params field on TriggerLogs LogEntry#1697
Open
startlingdan wants to merge 1 commit into
Open
Conversation
The S200B (Smart Button / dial) emits rotation events whose direction and magnitude live in `params.rotate_deg` (signed int, positive = clockwise, negative = anti-clockwise, magnitude in degrees). Today `LogEntry` strips the `params` field on parse, so callers can detect that a rotation happened but not which way. Add an optional `params: dict[str, Any] | None` field with default None. Fully backwards compatible (existing callers unaffected; events without params get None). Verified on a Tapo H100 firmware 1.6.1 with an S200B child: captured 9 events across `singleClick` and `rotation` types with the field exposed; `params.rotate_deg` populated for every rotation, absent for singleClick. Helps python-kasa#1117.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1697 +/- ##
=======================================
Coverage 93.22% 93.22%
=======================================
Files 157 157
Lines 9815 9816 +1
Branches 1003 1003
=======================================
+ Hits 9150 9151 +1
Misses 472 472
Partials 193 193 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rytilahti
requested changes
Jul 5, 2026
Member
There was a problem hiding this comment.
Thanks for the PR @startlingdan, the change looks straightforward, flaky CI on Windows is unrelated.
Given you know how the data looks like, could you already extract & parse it instead of passing it forward as raw data? Also, it would be great to have a fixture file showing this and tests for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S200B (Smart Button / dial) emits rotation events whose direction and magnitude live in
params.rotate_deg(signed int, positive = clockwise, negative = anti-clockwise, magnitude in degrees). TodayLogEntrystrips theparamsfield on parse, so callers can detect that a rotation happened but not which way.Add an optional
params: dict[str, Any] | Nonefield with default None. Fully backwards compatible (existing callers unaffected; events without params get None).Verified on a Tapo H100 firmware 1.6.1 with an S200B child: captured 9 events across
singleClickandrotationtypes with the field exposed;params.rotate_degpopulated for every rotation, absent for singleClick.Helps #1117.