Skip to content

Add support for D235(EU) doorbell#1678

Open
russellfinlay wants to merge 2 commits intopython-kasa:masterfrom
russellfinlay:feat/d235-doorbell
Open

Add support for D235(EU) doorbell#1678
russellfinlay wants to merge 2 commits intopython-kasa:masterfrom
russellfinlay:feat/d235-doorbell

Conversation

@russellfinlay
Copy link
Copy Markdown

First PR here, so please let me know if I've missed something!

PR adds device fixture and updates the list of support devices for the TP-Link Tapo D235(EU).

Resolves #1662

@ZeliardM
Copy link
Copy Markdown
Contributor

@russellfinlay Excellent, thanks! Some of the tests still fail when running the checks, that's nothing you did but it seems that your device and fixture format things differently that other devices and fixtures and this would need to be resolved before the fixture and support would full be added and resolved. I can keep an eye on this and see what I can work out.

@russellfinlay
Copy link
Copy Markdown
Author

Thanks @ZeliardM! Although I can't say that I'm a great programmer, I'm more than happy to help out where I can. Is there anything that you think I could look at at this stage maybe?

@ZeliardM
Copy link
Copy Markdown
Contributor

It's all good. No, not at this point. I'm currently doing a deep dive into the overall handling of the library. I'm going to start with different phases and suggestions to the maintainers about how to go about doing some things and seeing if we can get some better handling on the different devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add D235 support to python-kasa.

2 participants