Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| async def update_credentials(self, username: str, password: str) -> dict: | ||
| cur_pass = self.credentials.password if self.credentials.password else self.protocol._transport._default_credentials.password | ||
| cur_pass_hash = hashlib.sha256(cur_pass.encode()).hexdigest().upper() |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data High
| async def update_credentials(self, username: str, password: str) -> dict: | ||
| cur_pass = self.credentials.password if self.credentials.password else self.protocol._transport._default_credentials.password | ||
| cur_pass_hash = hashlib.sha256(cur_pass.encode()).hexdigest().upper() | ||
| new_pass_hash = hashlib.sha256(password.encode()).hexdigest().upper() |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data High
Contributor
Author
|
Superseded by #1664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer Tapo cameras use
changeAdminPasswordto update admin credentials on the device. Tested on my C206.As a note: it seems these devices limit functionality until the admin password is updated. I've noted on my C206 the Tapo camera stream would not load when provided default credentials, and my H200 hub would not find devices. The hub would respond successfully to API calls to start/stop scanning, but would not return any found devices. Only after updating credentials would it actually return found devices.