Skip to content

Update SSL AES Transport and default_credentials for encryption_type 3 #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZeliardM wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update SSL AES Transport and default_credentials for encryption_type 3 #1638

ZeliardM wants to merge 10 commits into from
+1,095 −6

Conversation

@ZeliardM
Copy link
Contributor

@ZeliardM ZeliardM commented Jan 9, 2026

Updates to get_default_credentials and DEFAULT_CREDENTIALS for handling a new default password for encryption_type 3 in TAPOCAMERA devices that use encryption_type 3.

Copilot AI review requested due to automatic review settings January 9, 2026 14:31
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ZeliardM ZeliardM mentioned this pull request Jan 10, 2026
Open
@ZeliardM ZeliardM mentioned this pull request Jan 19, 2026
Open
@ZeliardM ZeliardM requested a review from Copilot January 27, 2026 14:21
Copilot AI reviewed Jan 27, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (122849f) to head (a0c3749).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   92.82%   92.83%           
=======================================
  Files         157      157           
  Lines        9649     9652    +3     
  Branches      976      977    +1     
=======================================
+ Hits         8957     8960    +3     
  Misses        492      492           
  Partials      200      200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZeliardM
Copy link
Contributor Author

ZeliardM commented Jan 31, 2026

@rytilahti This one should be good as well, here's a summary of the PR:

  • Modified the default credentials to add a new TAPOCAMERA_LV3. Looking through the APK code found this new default password that was being used for the smartcamdevice.py for logging in if the username and password provided didn't work. This new password is selected from the login_version in the APK so that's what I did here.
    -Updated and modified all the tests to work with the new credentials and proper fixture handling for tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ZeliardM