Skip to content

Simplify mac address handling #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirichkov merged 1 commit into from
May 12, 2021
+8 −8
Merged

Simplify mac address handling #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions kasa/smartdevice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,16 +411,16 @@ def mac(self) -> str:
"""
sys_info = self.sys_info

if "mac" in sys_info:
return str(sys_info["mac"])
elif "mic_mac" in sys_info:
return ":".join(
format(s, "02x") for s in bytes.fromhex(sys_info["mic_mac"])
mac = sys_info.get("mac", sys_info.get("mic_mac"))
if not mac:
raise SmartDeviceException(
"Unknown mac, please submit a bug report with sys_info output."
)

raise SmartDeviceException(
"Unknown mac, please submit a bug report with sys_info output."
)
if ":" not in mac:
mac = ":".join(format(s, "02x") for s in bytes.fromhex(mac))

return mac

async def set_mac(self, mac):
"""Set the mac address.
Expand Down