Add preset support for Tapo cameras #1615

mrwogu · 2025-11-27T23:10:49Z

Add preset support for Tapo cameras (firmware 1.4.7+)

Description

This PR adds support for PTZ presets for Tapo cameras running newer firmware versions (e.g., C210 with firmware 1.4.7).

Problem

Newer firmware versions for Tapo cameras (like 1.4.7 for C210) have removed support for the generic motor module commands (get and do on motor preset), returning error code -40210 (Function not supported). This broke existing integrations that relied on these commands for preset management.

Solution

This PR implements the new API methods required by these firmware versions:

getPresetConfig: To retrieve the list of presets.
motorMoveToPreset: To move the camera to a specific preset.
addMotorPostion: To save a new preset (note: the typo in Postion is part of the official API).

The following methods have been added to the PanTilt module:

get_presets()
goto_preset(preset_id)
save_preset(name)

Testing

Tested locally with a Tapo C210 running firmware 1.4.7.

get_presets() correctly returns the list of presets.
goto_preset() successfully moves the camera.
save_preset() successfully saves a new preset.

codecov · 2025-11-27T23:18:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (347bf9a) to head (73503d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   92.82%   92.84%   +0.02%     
==========================================
  Files         157      157              
  Lines        9643     9678      +35     
  Branches      976      980       +4     
==========================================
+ Hits         8951     8986      +35     
  Misses        492      492              
  Partials      200      200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rytilahti

Thanks for the PR @mrwogu! This looks good to me on the surface, and it is ready to go after the tests are improved a bit.

I would suggest exposing this also through the feature interface as that makes it much easier to use in downstream (i.e., in the cli tool and in homeassistant), but I leave it for you to decide.

kasa/smartcam/modules/pantilt.py

tests/fakeprotocol_smartcam.py

tests/smartcam/modules/test_pantilt.py

mrwogu · 2025-11-30T10:20:57Z

Thanks for the suggestions, @rytilahti ! All changes have been implemented.

rytilahti

Thanks for the updates, looks much better! I added some more comments, mostly about making it cleaner and more consistent with the rest of our code base.

rytilahti · 2025-11-30T17:01:14Z

kasa/smartcam/modules/pantilt.py

+        presets_response = await self._device._query_helper(
+            "getPresetConfig", {"preset": {"name": ["preset"]}}
+        )


There is no need to manually query here, the query() will be used automatically.

You can then use the data property to access the module data like this:

python-kasa/kasa/smartcam/modules/alarm.py

Lines 110 to 113 in 347bf9a

@property

def alarm_sound(self) -> Annotated[str, FeatureAttribute()]:

"""Return current alarm sound."""

return self.data["getSirenConfig"]["siren_type"]

rytilahti · 2025-11-30T17:07:20Z

kasa/smartcam/modules/pantilt.py

+        if self._presets and "preset" not in self._module_features:
+
+            async def set_preset(preset_name: str) -> None:
+                preset_id = self._presets.get(preset_name)
+                if preset_id:
+                    await self.goto_preset(preset_id)
+
+            feature = Feature(
+                self._device,
+                "preset",
+                "Preset position",
+                container=self,
+                attribute_getter=lambda x: next(iter(self._presets.keys()), None),
+                attribute_setter=set_preset,
+                choices_getter=lambda: list(self._presets.keys()),
+                type=Feature.Type.Choice,
+            )
+            self._add_feature(feature)


Please move this into _initialize_features().

There is no need to check if the feature already exists, as it will be called only once after the first update (and it's _post_update_hook), so you can keep updating the internal _presets in the post update hook.

rytilahti · 2025-11-30T17:08:49Z

kasa/smartcam/modules/pantilt.py

+
+            feature = Feature(
+                self._device,
+                "preset",


Suggested change

"preset",

"ptz_preset",

Perhaps? There are other devices that have presets (e.g., lights), so it would be a good idea to avoid potential naming conflict if support for other presets is added at some point.

kasa/smartcam/modules/pantilt.py

rytilahti · 2025-11-30T17:11:45Z

tests/smartcam/modules/test_pantilt.py

+        assert preset_feature.value == first_preset_name
+
+        # Mock the protocol query for testing set_value
+        # This allows set_preset function body to be executed (lines 110-112)


Avoid naming lines as the code will live and these won't match anymore at some point.

rytilahti · 2025-11-30T17:12:44Z

tests/smartcam/modules/test_pantilt.py

+        call_args = mock_protocol_query.call_args
+        assert "motor" in str(call_args) or "preset" in str(call_args).lower()
+
+        # Reset mock


Suggested change

# Reset mock

No need for obvious comments, please check other similar comments in the tests, and ask yourself if they bring extra value for the reader :-)

rytilahti · 2025-11-30T17:23:10Z

tests/smartcam/modules/test_pantilt.py

+    if pantilt is None:
+        pytest.skip("Device does not have PanTilt module")


Suggested change

if pantilt is None:

pytest.skip("Device does not have PanTilt module")

Instead of doing this check for every separate test, it would be cleaner to define a new parametrization and then use it instead of @device_smartcam, for inspiration see:

python-kasa/tests/smartcam/modules/test_childsetup.py

Lines 12 to 18 in 347bf9a

childsetup = parametrize(

"supports pairing", component_filter="childQuickSetup", protocol_filter={"SMARTCAM"}

)

@childsetup

async def test_childsetup_features(dev: Device):

rytilahti · 2025-11-30T17:25:13Z

tests/smartcam/modules/test_pantilt.py

+    try:
+        await preset_feature.set_value(invalid_preset_name)
+        # goto_preset should NOT be called because preset_id is empty string (falsy)
+        mock_query.assert_not_called()


Trying to set an invalid value should raise a ValueError, right? You could use with pytest.raises(ValueError) to make sure that is happening.

mrwogu · 2025-12-01T12:26:24Z

Thanks again for your valuable feedback, @rytilahti. They helped me understand exactly how this should work. I refactored it. It should be fine now.

mrwogu force-pushed the fix/tapo-c210-presets branch from e75e186 to c7fe2f9 Compare November 27, 2025 23:15

mrwogu force-pushed the fix/tapo-c210-presets branch 5 times, most recently from bd856bf to 20e8f10 Compare November 27, 2025 23:46

Add preset support for Tapo cameras (firmware 1.4.7+)

43e77ce

mrwogu force-pushed the fix/tapo-c210-presets branch from 20e8f10 to 43e77ce Compare November 27, 2025 23:48

rytilahti requested changes Nov 28, 2025

View reviewed changes

mrwogu force-pushed the fix/tapo-c210-presets branch from ee98828 to c5897ac Compare November 29, 2025 21:06

refactor: add Feature.Type.Choice for preset selection

1fecad5

mrwogu force-pushed the fix/tapo-c210-presets branch 5 times, most recently from cfc865d to dc69f12 Compare November 30, 2025 09:57

test: preset feature

1eee003

mrwogu force-pushed the fix/tapo-c210-presets branch from dc69f12 to 1eee003 Compare November 30, 2025 10:15

rytilahti requested changes Nov 30, 2025

View reviewed changes

rytilahti added the enhancement New feature or request label Nov 30, 2025

rytilahti changed the title ~~Add preset support for Tapo cameras (firmware 1.4.7+)~~ Add preset support for Tapo cameras Nov 30, 2025

refactor: rewrite presets feature

73503d6

mrwogu force-pushed the fix/tapo-c210-presets branch from 145a6fa to 73503d6 Compare December 1, 2025 12:19

mrwogu requested a review from rytilahti December 1, 2025 23:13

	@property
	def alarm_sound(self) -> Annotated[str, FeatureAttribute()]:
	"""Return current alarm sound."""
	return self.data["getSirenConfig"]["siren_type"]

		if pantilt is None:
		pytest.skip("Device does not have PanTilt module")

	childsetup = parametrize(
	"supports pairing", component_filter="childQuickSetup", protocol_filter={"SMARTCAM"}
	)


	@childsetup
	async def test_childsetup_features(dev: Device):

Uh oh!

Add preset support for Tapo cameras #1615

Are you sure you want to change the base?

Add preset support for Tapo cameras #1615

Uh oh!

Conversation

mrwogu commented Nov 27, 2025

Add preset support for Tapo cameras (firmware 1.4.7+)

Description

Problem

Solution

Testing

Uh oh!

codecov bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrwogu commented Nov 30, 2025

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

rytilahti Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

mrwogu commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Nov 27, 2025 •

edited

Loading