Skip to content

Conversation

@brianthedavis
Copy link
Contributor

  • Added KL125 1.20 color bulb fixture
  • Added HS200 5.0 wall switch fixture
  • Updated the conftest.py to automatically include any COLOR_BULBS or VARIABLE_TEMP bulbs in the BULBS device set (I spent a good 10 minutes scratching my head on why I couldn't get this to work until I realized the convention used....this seems to make more sense to not accidentally omit a device type)
  • Added a check within newfakes.py to safely skip over the emeter key if it's not in the fixture dump (which it's not on the new fixtures added)

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #160 (5bb6700) into master (0471e1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          11       11           
  Lines        1220     1220           
  Branches      177      177           
=======================================
  Hits          908      908           
  Misses        279      279           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0471e1a...5bb6700. Read the comment docs.

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@rytilahti rytilahti merged commit 28a902c into python-kasa:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants