-
-
Notifications
You must be signed in to change notification settings - Fork 246
Add python 3.14 to supported versions #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
7c8da1f
e8f1889
215fcf5
434e5f2
301cbc1
0af5536
5b7a960
ba67111
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,7 +96,7 @@ def _device_to_serializable(val: Device): | |
|
|
||
|
|
||
| async def invoke_subcommand( | ||
| command: click.BaseCommand, | ||
| command: click.Command, | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Spotted by mypy, |
||
| ctx: click.Context, | ||
| args: list[str] | None = None, | ||
| **extra: Any, | ||
|
|
@@ -200,7 +200,7 @@ def _list_children(): | |
| if child_option is not None: | ||
| if child_option is OPTIONAL_VALUE_FLAG: | ||
| msg = _list_children() | ||
| child_index_option = click.prompt( | ||
| child_index_option = await click.prompt( | ||
| f"\n{msg}\nEnter the index number of the child device", | ||
| type=click.IntRange(0, len(device.children) - 1), | ||
| ) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -743,6 +743,8 @@ def _get_device_instance_legacy(info: dict, config: DeviceConfig) -> Device: | |
| device = device_class(config.host, config=config) | ||
| sys_info = _extract_sys_info(info) | ||
| device_type = sys_info.get("mic_type", sys_info.get("type")) | ||
| if device_type is None: | ||
| raise UnsupportedDeviceError("type nor mic_type found in sysinfo response") | ||
|
Comment on lines
+746
to
+747
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsure why this was not spotted earlier by mypy, but |
||
| login_version = ( | ||
| sys_info.get("stream_version") if device_type == "IOT.IPCAMERA" else None | ||
| ) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary as pyproject.toml uses now standard dependecy groups.