Skip to content

Conversation

@rytilahti
Copy link
Member

We frequently receive reports from users who have issues with credentials.
One of the most common cases, besides the mobile app users' uppercasing the first letter, is due to the provisioning through "tplink simple setup" (tss) where the newly provisioned devices do not accept the regular credentials.

This PR adds a new exception that can be caught to display user a more detailed message about what they can do to fix the issue.

This has not been tested yet, so drafting for now.

Fixes #1573

@rytilahti rytilahti added the enhancement New feature or request label Oct 11, 2025
@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.68%. Comparing base (1a89a1c) to head (d6c3584).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
kasa/cli/discover.py 57.14% 2 Missing and 1 partial ⚠️
kasa/discover.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
- Coverage   92.73%   92.68%   -0.05%     
==========================================
  Files         157      157              
  Lines        9630     9636       +6     
  Branches      976      978       +2     
==========================================
+ Hits         8930     8931       +1     
- Misses        499      502       +3     
- Partials      201      203       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZeliardM
Copy link
Contributor

@rytilahti I wanted to let you know that I had a user report an issue with the homebridge-kasa-python plugin about this but the obd_src was "amazon_atr" and it was discovering the device but failing to authenticate until they re-added it as "tplink".

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added stale and removed stale labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve incorrect credentials handling for tss provisioning

2 participants