Skip to content

Add support for plugs with emeters. #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendandburns wants to merge 1 commit into from
Closed

Add support for plugs with emeters. #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions kasa/smartstrip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

from kasa.smartdevice import (
DeviceType,
EmeterStatus,
SmartDevice,
SmartDeviceException,
requires_update,
Expand Down Expand Up @@ -154,6 +155,35 @@ async def set_alias(self, alias: str) -> None:
"""
return await super().set_alias(alias)

@requires_update
async def get_emeter_realtime(self) -> EmeterStatus:
"""Retrieve current energy readings."""
if not self.has_emeter:
raise SmartDeviceException("Device has no emeter")

plug_emeter = False
for plug in self.children:
if plug.has_emeter:
plug_emeter = True

if not plug_emeter:
return EmeterStatus(await self._query_helper(self.emeter_type, "get_realtime"))

emeter_rt: DefaultDict[int, float] = defaultdict(lambda: 0.0)
count = 0
for plug in self.children:
if not plug.has_emeter:
Copy link
Contributor

@kirichkov kirichkov Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a real-world case, where some sockets on the same strip have and some sockets don't have emeter? If not I think this would be redundant

continue
count += 1
plug_emeter_rt = await plug.get_emeter_realtime()
for field, value in plug_emeter_rt.items():
emeter_rt[field] += value

# Voltage is averaged
emeter_rt['voltage_mv'] /= count
Copy link
Contributor

@kirichkov kirichkov Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea here, but have you ever noticed the individual plugs reporting different voltage? Normally you should get the same voltage from each child-plug.


return EmeterStatus(emeter_rt)

@requires_update
async def get_emeter_daily(
self, year: int = None, month: int = None, kwh: bool = True
Expand Down Expand Up @@ -247,12 +277,6 @@ def led(self) -> bool:
"""
return False

@property # type: ignore
@requires_update
def has_emeter(self) -> bool:
"""Children have no emeter to my knowledge."""
return False

@property # type: ignore
@requires_update
def device_id(self) -> str:
Expand Down