Leverage data from UDP discovery to initialize device structure #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 73.02% 72.98% -0.04%
==========================================
Files 10 10
Lines 1227 1229 +2
Branches 183 183
==========================================
+ Hits 896 897 +1
- Misses 298 299 +1
Partials 33 33
Continue to review full report at Codecov.
|
rytilahti
reviewed
Feb 5, 2021
Member
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
This is a great improvement, thanks a lot! I haven't tested it personally, but it reads reasonable. Could you remove the .gitignore modification though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoids unnecessary subsequent TCP calls to device