Skip to content

Conversation

@sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Sep 21, 2024

If approved we need to create the stale, no-stale, needs-more-information, and waiting-for-reporter labels before merging.

@codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (73b6d16) to head (941ec92).
Report is 211 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files          96       96           
  Lines        6117     6117           
  Branches     1510     1510           
=======================================
  Hits         5666     5666           
  Misses        353      353           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti
Copy link
Member

Could we make do with just only two labels: "stale" and "needs-more-information"? Although given that our inbox for PRs and issues is rather short, I'm not sure if it's worth to close issues & PRs automatically :-)

@sdb9696
Copy link
Collaborator Author

sdb9696 commented Sep 21, 2024

We do have 66 open issues, some going back 4 years, which is quite a lot 😂. Can definately drop waiting-for-reporter but I think we should keep no-stale so we can mark certain issues not to be closed.

@rytilahti
Copy link
Member

Some of those are our own to-do list items, so I wouldn't worry much about them. We could convert the issues that still make sense into a project to track them more nicely, but I don't personally like auto-closing of (unresolved) issues as open ones appear directly when searching.

That being said, I'm not against performing some actions to make reporters/contributors aware through notifications what this would do, so I'd say it's your call :-)

@sdb9696
Copy link
Collaborator Author

sdb9696 commented Sep 27, 2024

Let's go with this as I think it's good to have a more manageable list and also give consumers an opportunity to keep things alive and show engagement. Anything we want to keep for ourselves we should mark as no-stale when we get the notification.

@sdb9696 sdb9696 merged commit 5d78f00 into master Sep 27, 2024
@sdb9696 sdb9696 deleted the janitor/stale_issues branch September 27, 2024 16:34
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Sep 27, 2024
@sdb9696 sdb9696 added this to the 0.7.4 milestone Sep 27, 2024
@sdb9696 sdb9696 mentioned this pull request Sep 27, 2024
sdb9696 added a commit that referenced this pull request Sep 27, 2024
## [0.7.4](https://github.com/python-kasa/python-kasa/tree/0.7.4) (2024-09-27)

[Full Changelog](0.7.3...0.7.4)

**Release summary:**

- KL135 color temp range corrected to 9000k max
- Minor enhancements and project maintenance

**Implemented enhancements:**

- Add factory\_reset\(\) to iotdevice [\#1125](#1125) (@rytilahti)
- Add reboot\(\) to the device interface [\#1124](#1124) (@rytilahti)
- Add factory-reset command to cli [\#1108](#1108) (@rytilahti)

**Fixed bugs:**

- Extend KL135 ct range up to 9000K [\#1123](#1123) (@rytilahti)
- Fix cli command for device off [\#1121](#1121) (@sdb9696)

**Project maintenance:**

- Use pytest-socket to ensure no tests are performing io [\#1133](#1133) (@sdb9696)
- Enable ruff lint pycodestyle warnings [\#1132](#1132) (@sdb9696)
- Add autouse fixture to patch asyncio.sleep [\#1131](#1131) (@sdb9696)
- Mock asyncio.sleep for klapprotocol tests [\#1130](#1130) (@rytilahti)
- Add fixture for T110 fw 1.9.0 [\#1129](#1129) (@rytilahti)
- Speed up and simplify github workflows [\#1128](#1128) (@sdb9696)
- Add KS200M\(US\) fw 1.0.12 fixture [\#1127](#1127) (@GatorEG)
- Add stale PR/Issue github workflow [\#1126](#1126) (@sdb9696)
- Add fixture for KL135\(US\) fw 1.0.15 [\#1122](#1122) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Project improvements and maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants