Skip to content

Conversation

@rytilahti
Copy link
Member

Both device families have already had a method following this signature, but defining the interface in the base class will make the contract clear.

@rytilahti rytilahti added the enhancement New feature or request label Sep 21, 2024
@rytilahti rytilahti requested a review from sdb9696 September 21, 2024 11:25
@codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (5df6c76) to head (c04af9d).
Report is 207 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          96       96           
  Lines        6110     6112    +2     
  Branches     1506     1507    +1     
=======================================
+ Hits         5658     5660    +2     
  Misses        354      354           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rytilahti rytilahti merged commit f07341a into python-kasa:master Sep 21, 2024
@rytilahti rytilahti deleted the janitor/reboot_to_basedevice branch September 21, 2024 14:44
@sdb9696 sdb9696 added this to the 0.7.4 milestone Sep 27, 2024
@sdb9696 sdb9696 mentioned this pull request Sep 27, 2024
sdb9696 added a commit that referenced this pull request Sep 27, 2024
## [0.7.4](https://github.com/python-kasa/python-kasa/tree/0.7.4) (2024-09-27)

[Full Changelog](0.7.3...0.7.4)

**Release summary:**

- KL135 color temp range corrected to 9000k max
- Minor enhancements and project maintenance

**Implemented enhancements:**

- Add factory\_reset\(\) to iotdevice [\#1125](#1125) (@rytilahti)
- Add reboot\(\) to the device interface [\#1124](#1124) (@rytilahti)
- Add factory-reset command to cli [\#1108](#1108) (@rytilahti)

**Fixed bugs:**

- Extend KL135 ct range up to 9000K [\#1123](#1123) (@rytilahti)
- Fix cli command for device off [\#1121](#1121) (@sdb9696)

**Project maintenance:**

- Use pytest-socket to ensure no tests are performing io [\#1133](#1133) (@sdb9696)
- Enable ruff lint pycodestyle warnings [\#1132](#1132) (@sdb9696)
- Add autouse fixture to patch asyncio.sleep [\#1131](#1131) (@sdb9696)
- Mock asyncio.sleep for klapprotocol tests [\#1130](#1130) (@rytilahti)
- Add fixture for T110 fw 1.9.0 [\#1129](#1129) (@rytilahti)
- Speed up and simplify github workflows [\#1128](#1128) (@sdb9696)
- Add KS200M\(US\) fw 1.0.12 fixture [\#1127](#1127) (@GatorEG)
- Add stale PR/Issue github workflow [\#1126](#1126) (@sdb9696)
- Add fixture for KL135\(US\) fw 1.0.15 [\#1122](#1122) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants