Simplify device class detection for discovery, fix hardcoded timeout #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 72.88% 73.02% +0.13%
==========================================
Files 10 10
Lines 1232 1227 -5
Branches 185 183 -2
==========================================
- Hits 898 896 -2
+ Misses 300 298 -2
+ Partials 34 33 -1
Continue to review full report at Codecov.
|
rytilahti
referenced
this pull request
in Belval/python-kasa
Nov 7, 2020
Contributor
|
Thanks for fixing the timeout issue! I meant to report that last week but forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the device class detection is made purely using the information available in the
system.get_sysinfocall.This will make it easier to approach fixing #105