Skip to content

Fix mypy pre-commit hook on windows #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdb9696 merged 2 commits into from
Jul 25, 2024
Merged

Fix mypy pre-commit hook on windows #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e76fa05
Fix pre-commit on windows
sdb9696 Jul 24, 2024
8477032
Merge branch 'master' into fix/pre_commit_win
sdb9696 Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions devtools/run-in-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
#!/bin/bash
source $(poetry env info --path)/bin/activate
#!/usr/bin/env bash

OS_KERNEL=$(uname -s)
OS_VER=$(uname -v)
if [[ ( $OS_KERNEL == "Linux" && $OS_VER == *"Microsoft"* ) ]]; then
echo "Pre-commit hook needs git-bash to run. It cannot run in the windows linux subsystem."
echo "Add git bin directory to the front of your path variable, e.g:"
echo "set PATH=C:\Program Files\Git\bin;%PATH%"
exit 1
fi
if [[ "$(expr substr $OS_KERNEL 1 10)" == "MINGW64_NT" ]]; then
POETRY_PATH=$(poetry.exe env info --path)
source "$POETRY_PATH"\\Scripts\\activate
else
source $(poetry env info --path)/bin/activate
fi
exec "$@"
3 changes: 2 additions & 1 deletion kasa/discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ def connection_made(self, transport) -> None:
except OSError as ex: # WSL does not support SO_REUSEADDR, see #246
_LOGGER.debug("Unable to set SO_REUSEADDR: %s", ex)

if self.interface is not None:
# windows does not support SO_BINDTODEVICE
if self.interface is not None and hasattr(socket, "SO_BINDTODEVICE"):
sock.setsockopt(
socket.SOL_SOCKET, socket.SO_BINDTODEVICE, self.interface.encode()
)
Expand Down