1. Run 'black' before patching.

Done.

2. I think the best solution is to move lines 338-344 to be below 331, and part of that else block.

This makes sense, and allows eliminations of the returns for the year and month blocks. I'll implement after we resolve the list instance issue.

3. Move the check for isinstance (

I don't understand this. Both definitions of get_emeter_monthly and get_emeter_daily return dicts (smartdevice.py, smartstrip.py). So any test for list instances will always fail for these methods.

I don't know where the lists are supposed to come from, but it is absolutely not from the monthly/yearly methods as currently implemented. I'd assumed this was to capture smartstrip summary data.

I don't know where the lists are supposed to come from, but it is absolutely not from the monthly/yearly methods as currently implemented. I'd assumed this was to capture smartstrip summary data.

Oooops! You are right! I'm sorry for the misdirection I gave you!

@rytilahti any idea why the CLI is still checking for emeter returning lists when no such thing is returned from any of the emeter functions?

Sorry, I currently have very spotty internet connectivity. But the idea is correct, yearly and monthly responses should be handled separately to the realtime one (the information is different for the historical responses). I think the incorrect behavior is just a leftover from the port, I cannot really recall why I thought the historical data would be reported in the same format but in a list.

In my opinion the best way is to deal the historical data completely separately from the real time data. Please feel free to use a prettier output format than simply echoing out the response from the calls.

(please also update the PR title to be more informative, thanks!)

OK - with the last round of comments, I think I can do a clean implementation. Update to follow in a day or so.

For the historical data, how about something like this (works well for as I can then translate to excel data sets trivially)?

== For year 2020 ==
    Month, Monthly usage (kWh) 
         4, 80.9
         5, 62.3
         6. 18.0

CSV-like looks good to me. Makes it easier to parse too.

OK - I think that will do it. I ended up doing plain CSV with no spacing to make copy/pasting data simpler.

@rytilahti It looks good to me, let me know if I can merge or do so yourself if your Internet has improved :-)

Hey, sorry for the delay! I just tested this with my hs110 and it looks fine to me, so let's get it merged. Thanks for the PR! 🎉

While I think the output format is fine as it is, if CSV output is really wanted it is far easier to less cumbersome to create a simple script to do that. The reason is that we are not giving any guarantees to the cli tool's output format while we have (I think so at least :-) an unwritten rule about not breaking the API for no reason.