update url to gitlab-ci schema #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsch
force-pushed
the
fix-gitlab-ci-schema
branch
from
d5e6b9d to
034ba19
Compare
Member
|
Oh, wow! Thanks for this, and that was an embarrassing mistake to have in the repo. I'm going to merge this, and I'll credit you in the changelog + add the license in a few minutes. I've been including the original licenses with some notes in the vendored schemas dir readme whenever pulling a schema from a new/distinct source. Clearly I also need to fix the vendoring script to treat that sort of response as an error. You can expect a release with this fix by end of day today. I'll get it done shortly. |
sirosen
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #66
The gitlab-ci schema was remove from schemastore repository and replaced by link to the file in gitlab repository.
I'm not sure how to handle the licensing of the schema file. Gitlab license states that client-side JavaScript (as far as I understand ci.json is part of the editor) are licensed under "MIT Expat" license.