Support expressions in GHA require-timeout schema #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-workflows-require-timeout now supports expression eval blocks in the value for the timeout. Two test-cases ensure that such workflows will pass, based on the example provided in #354 resolves #354 There is also a small refinement to test outputs here, which was added while testing this addition.
webknjaz
added a commit
to aio-libs/frozenlist
that referenced
this pull request
Dec 14, 2023
Previously, the jsonschema for non-raw number values was incomplete but has been fixed in check-jsonschema v0.27.2. Refs: * python-jsonschema/check-jsonschema#354 * python-jsonschema/check-jsonschema#356
webknjaz
added a commit
to aio-libs/yarl
that referenced
this pull request
Dec 15, 2023
Previously, the jsonschema for non-raw number values was incomplete but has been fixed in check-jsonschema v0.27.2. Refs: * python-jsonschema/check-jsonschema#354 * python-jsonschema/check-jsonschema#356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github-workflows-require-timeout now supports expression eval blocks in the value for the timeout. Two test-cases ensure that such workflows will pass, based on the example provided in #354
resolves #354
There is also a small refinement to test outputs here, which was added while testing this addition.