Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-jsonschema/check-jsonschema
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.13.0
Choose a base ref
...
head repository: python-jsonschema/check-jsonschema
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.14.0
Choose a head ref
  • 18 commits
  • 43 files changed
  • 4 contributors

Commits on Feb 21, 2022

  1. [pre-commit.ci] pre-commit autoupdate (#48)

    updates:
    - [github.com/sirosen/check-jsonschema: 0.11.0 → 0.13.0](0.11.0...0.13.0)
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    pre-commit-ci[bot] authored Feb 21, 2022
    Configuration menu
    Copy the full SHA
    2255ee7 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Move the repo to python-jsonschema (#49)

    This is a new org created to hold check-jsonschema and the jsonschema
    package. As the repo has moved, various docs &c need minor tweaks to
    avoid extra redirects through the old name.
    sirosen authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    afa6ced View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. [vendor-schemas] automated update (#51)

    Co-authored-by: sirosen <sirosen@users.noreply.github.com>
    github-actions[bot] and sirosen authored Feb 23, 2022
    Configuration menu
    Copy the full SHA
    8fb8f9b View commit details
    Browse the repository at this point in the history
  2. Add check-metaschema hook and use it in tests (#50)

    Rather than dedicated testing for `metaschemas/...`, the metaschema
    hook can now be tested under the hook example files.
    
    The configuration is basically the same as any other hook. As there
    are schema-authors interested in writing YAML schemas, the YAML format
    is supported for this purpose.
    
    Add some YAML schema files for metaschema tests
    sirosen authored Feb 23, 2022
    Configuration menu
    Copy the full SHA
    e830581 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Changes by create-pull-request action (#52)

    * [vendor-schemas] automated update
    
    * Update CHANGELOG.md
    github-actions[bot] authored Feb 25, 2022
    Configuration menu
    Copy the full SHA
    de88be3 View commit details
    Browse the repository at this point in the history
  2. Adjust test suite layout

    - move unit tests to `unit/`
    - move the configured hooks test to the acceptance test dir
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    7dd8d3f View commit details
    Browse the repository at this point in the history
  3. Improve testing of mutex options

    Parametrize tests over several sets of mutex options. Check that the
    correct error is raised. Fix the absence of a required positional
    which stopped the test from reaching the correct error.
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    d010045 View commit details
    Browse the repository at this point in the history
  4. Improve format checker tests

    - use a parametrized fixture rather than the same param list for each
      test
    - check error messages against stderr
    - check format checker behavior on non-str data
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    1314a12 View commit details
    Browse the repository at this point in the history
  5. Ensure tests cover additional urlinfo schemes

    Make sure positive and negative test cases pass for 'file://' schemas.
    Add a negative test case for a non-file, non-http(s) scheme, 'ftp://'
    is used in the test as a "plausible" example.
    
    In order for the test to pass, explicit handling needs to be
    introduced for the UnsupportedUrlScheme error case, and the schema
    reader object needs to be initialized lazily.
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    fdcadf0 View commit details
    Browse the repository at this point in the history
  6. Fix handling of local file URIs on Windows

    Given a local file URI on Windows, e.g. `file:///C:/foo.txt`, the path
    was not properly being deduced as a Windows-native absolute path.
    Instead, the path would be converted to a URI path with posix-like
    notation, like `/C:/foo.txt`. The result didn't work for local
    relative ref resolution because the resulting pathlib.Path object
    isn't absolute (wrong slashes).
    
    The fix is more manual and explicit handling of the file-URI case when
    converting into a pathlib.Path object in the first place. Using
    `urllib.requests.url2pathname`, imitate the solution from `pip` for
    this same problem, simplifying a bit for the relevant case.
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    56935d9 View commit details
    Browse the repository at this point in the history
  7. Set tests to treat warning as errors; fix warnings

    `filterwarnings=error`, which flags the following things to fix:
    - match_querystring=False vs match_querystring=None for
      responses==0.17.0 (last version with py3.6 support)
    - importlib_resources.files() vs "legacy" functions
    
    To handle importlib_resources, it's important to tweak the
    importlib_resources requirement to 'python_version<"3.9"'. This
    guarantees that we always use a version which supports the newer
    `files()` API.
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    94ea425 View commit details
    Browse the repository at this point in the history
  8. Be more careful about file modes

    Ensure we open files as binary. The alternative would be to use
    `encoding="utf-8"` explicitly. Either is fine -- the point is to be
    consistent.
    sirosen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    814f1ca View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2022

  1. Changes by create-pull-request action (#53)

    * [vendor-schemas] automated update
    
    * Update CHANGELOG.md
    github-actions[bot] authored Feb 26, 2022
    Configuration menu
    Copy the full SHA
    4d4fe20 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Changes by create-pull-request action (#54)

    * [vendor-schemas] automated update
    
    * Update CHANGELOG.md
    github-actions[bot] authored Feb 28, 2022
    Configuration menu
    Copy the full SHA
    f8a70bf View commit details
    Browse the repository at this point in the history
  2. Drop support for py36 and remove compat code

    Compat code for py36 to workaround versions of `identify` and
    `jsonschema` can be removed if we move to py3.7+ only.
    
    Update the build matrices, and the python_requires package metadata.
    
    Set new lower bounds for `jsonschema` and `identify` to match the
    needed newer features.
    sirosen committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    22e6fb6 View commit details
    Browse the repository at this point in the history
  3. Update style for py3.7: annotations

    Import future annotations and use pyupgrade to update the style of
    annotations in use throughout the codebase. Add some annotations where
    appropriate.
    sirosen committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    dc92c53 View commit details
    Browse the repository at this point in the history
  4. Begin enforcing type checking, update changelog

    - setup mypy
    - enable mypy in CI and add it to `make lint`
    - do requisite cleanup to make mypy pass
    - add a changelog note for removal of py36 and addition of
      mypy usage
    sirosen committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    6af2cf4 View commit details
    Browse the repository at this point in the history
  5. Bump version for release

    sirosen committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    1071851 View commit details
    Browse the repository at this point in the history
Loading