Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A supported
permessage-deflateoffer followed by an unsupported alternative can change the extension object after the response parameters have been chosen. For example, a laterclient_no_context_takeover; server_max_window_bits=8offer is declined, but leaves context takeover disabled internally while the response still allows it. The first compressed message succeeds; the second closes with a decompression error.Keep the first accepted offer for each extension name and skip later alternatives. Declined offers still allow fallback, and other extension names are still processed. This follows the client preference order described in RFC 7692 §5.
Validation:
python -bb -m pytest; on 3.12 also--cov=wsproto --cov-report=term --cov-report=xml). Line/branch coverage increased from 96.57% to 97.11%; both added source lines and both guard branches are covered.mypy src/(strict), Ruff check/format for the new test,make -C docs clean html,check-manifest,python -m build --outdir dist/, andtwine check dist/*passed.Validated on macOS arm64. Other Python/platform combinations await upstream CI. The existing UV all-groups resolver fails on the project's Python 3.10/Sphinx 8 constraint; the declared groups were installed into the Python 3.12 environment using
uv pip install -e . --group dev, without changing dependencies.Prepared with OpenAI Codex automation. No human review is claimed.