Repository navigation
Test isolation of active locales between threads - #493
Open
Alex-ardashev wants to merge 1 commit into
Open
Alex-ardashev wants to merge 1 commit into
Alex-ardashev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a synchronized two-thread test for locale isolation. It checks that a new thread starts in the default locale, activating French does not change the main thread's German locale, and deactivation in the main thread does not reset the worker's French locale.
The test checks translation selection and formatted numbers. It uses cached translation objects so it does not need compiled catalogs. Events have bounded waits, and both threads restore their default locale.
Validation on macOS, Python 3.12.5:
tox -e py -- --benchmark-disable: 879 passed, with compiled catalogs. Local pytest was set to 9.1.1 because 9.2.0 raises an unrelated_nodeiderror in the existing benchmark fixture.tox -e mypyandprek run --files tests/test_i18n.py: passed.This change adds test coverage; it does not change runtime behavior.