Skip to content

Fix constructing Gitlab object without authentication #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jalr wants to merge 1 commit into from
Closed

Fix constructing Gitlab object without authentication #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gitlab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def _set_auth_info(self):
bool(arg)
for arg in [self.private_token, self.oauth_token, self.job_token]
)
!= 1
> 1
Copy link
Member

@max-wittig max-wittig Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this does exactly the reverse. It only works, if we have multiple parameters.

We should only check this condition, if the items are larger than 1

):
raise ValueError(
"Only one of private_token, oauth_token or job_token should "
Expand Down