Skip to content

Remove unused code and simplify string format. #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-wittig merged 1 commit into from
Oct 6, 2019
Merged

Remove unused code and simplify string format. #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gitlab/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def total(self):
class RESTManager(object):
"""Base class for CRUD operations on objects.

Derivated class must define ``_path`` and ``_obj_cls``.
Derived class must define ``_path`` and ``_obj_cls``.

``_path``: Base URL path on which requests will be sent (e.g. '/projects')
``_obj_cls``: The class of objects that will be created
Expand Down
2 changes: 1 addition & 1 deletion gitlab/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def _get_base_parser(add_help=True):
"-c",
"--config-file",
action="append",
help=("Configuration file to use. Can be used " "multiple times."),
help="Configuration file to use. Can be used multiple times.",
)
parser.add_argument(
"-g",
Expand Down
2 changes: 1 addition & 1 deletion gitlab/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def __init__(self, gitlab_id=None, config_files=None):
self.gitlab_id = self._config.get("global", "default")
except Exception:
raise GitlabIDError(
"Impossible to get the gitlab id " "(not specified in config file)"
"Impossible to get the gitlab id (not specified in config file)"
)

try:
Expand Down
3 changes: 0 additions & 3 deletions gitlab/tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ class MGR(base.RESTManager):
class Parent(object):
id = 42

class BrokenParent(object):
no_id = 0

mgr = MGR(FakeGitlab(), parent=Parent())
self.assertEqual(mgr._computed_path, "/tests/42/cases")

Expand Down