Skip to content

Fix avatar uploading for projects #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-wittig merged 1 commit into from
Aug 22, 2019
Merged

Fix avatar uploading for projects #861

max-wittig merged 1 commit into from
Aug 22, 2019

Conversation

@ravanscafi
Copy link

@ravanscafi ravanscafi commented Aug 14, 2019

The avatar attribute was already set for projects but it wasn't working because the type was missing.

@ravanscafi
Copy link
Author

ravanscafi commented Aug 21, 2019

@max-wittig could you please take a look?
It's a really simple change, I'm using it and can ensure that it works.

Thanks!

max-wittig
max-wittig approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MR 👍

@max-wittig max-wittig merged commit 99a9415 into python-gitlab:master Aug 22, 2019
@ravanscafi ravanscafi deleted the fix-project-avatar branch August 22, 2019 17:25
@ravanscafi ravanscafi restored the fix-project-avatar branch August 22, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ravanscafi @max-wittig