fix(api): avoid parameter conflicts with python and gitlab #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpocentek
force-pushed
the
no-param-conflicts
branch
from
138837d to
1554510
Compare
max-wittig
requested changes
Jan 13, 2019
Member
max-wittig
left a comment
max-wittig
left a comment
There was a problem hiding this comment.
This is a difficult conceptual problem to solve and this seems like a good compromise (usability vs. edge cases).
I just noticed the the minor typos, otherwise looks good and works as expected 👍
gpocentek
force-pushed
the
no-param-conflicts
branch
from
1554510 to
4bd027a
Compare
Contributor
Author
|
Thanks for the review! |
Contributor
Author
|
Typos fixed and checked passed, let me know if this looks OK to you. |
Member
|
Sorry totally forgot about this. Looks good to me. Let's merge it. |
max-wittig
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide another way to send data to gitlab with a new
query_parametersargument. This parameter can be used to explicitly define the dict of
items to send to the server, so that **kwargs are only used to specify
python-gitlab specific parameters.
Closes #566
Closes #629