Skip to content

Conversation

@esabouraud
Copy link
Contributor

This PR introduces support for protected tags management.

@esabouraud
Copy link
Contributor Author

Hi @gpocentek, is there anything wrong with this PR ? Gitlab 11.3 is now released so this new API is available for general use.

@gpocentek
Copy link
Contributor

Hi @esabouraud

Sorry for the delay but I don't have a lot of time for reviews these days.

@max-wittig @hans-d do you think you could have a look?

@max-wittig max-wittig self-assigned this Oct 3, 2018
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@max-wittig
Copy link
Member

@hans-d Do you want to take another look or can we merge?

@gpocentek gpocentek merged commit ea71f1d into python-gitlab:master Oct 3, 2018
@hans-d
Copy link
Contributor

hans-d commented Oct 3, 2018

@max-wittig if it's LGTM no need to specifically wait for me unless you have doubts...

@esabouraud esabouraud deleted the feature-protectedtags branch October 4, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants