Support api-objects which don't have id in api response.#44
Merged
gpocentek merged 2 commits intopython-gitlab:masterfrom Oct 24, 2014
Merged
Support api-objects which don't have id in api response.#44gpocentek merged 2 commits intopython-gitlab:masterfrom
gpocentek merged 2 commits intopython-gitlab:masterfrom
Conversation
gpocentek
pushed a commit
that referenced
this pull request
Oct 24, 2014
Support api-objects which don't have id in api response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gitlab api Repository File and Label objects don't use id on get, post, put or delete. File uses url ending with /files for all operations and Label uses /label.
_created boolean is used to distinguish between create and update instead of presense of id.
In addition to that Label returns list with get and File returns object. getListWhenNoId boolean is used to distinguish between them.