Merged
Conversation
Contributor
Author
|
Using six would be fine. Initially I didn't want to add a new dependency to six, because there was only few places that needed updates. I can update pull request tomorrow with a version that uses six. |
Contributor
|
I don't mind adding a dependency on six. An update would be nice. Thanks for your work! |
Contributor
Author
|
I updated with new version that uses six. I did not change dictionary iteration with .items() to use six, because it is mostly used to iterate over dictionary. In two places where dictionary is modified during iteration, I added explicit conversion to list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3 does not have unicode type.
Added future import for print_function so that print is handled same in both 2 and 3.
Added future imports for division and absolute import for future compatiblity even though they are not currently needed.